Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade alpine, use iptables-legacy #327

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

siggy
Copy link
Member

@siggy siggy commented Jan 24, 2024

PR #307 bumps alpine to 3.19.0. Unfortunately that version defaults to iptables-nft. This breaks an assumption in our Dockerfile and proxy-init that the iptables binary is the legacy version.

Bump alpine to 3.19.0, modify the Dockerfile to continue installing iptables-legacy, and modify the proxy-init command to default to iptables-legacy.

PR #307 bumps alpine to 3.19.0. Unfortunately that version defaults to
iptables-nft. This breaks an assumption in our Dockerfile and proxy-init
that the `iptables` binary is the legacy version.

Bump alpine to 3.19.0, modify the Dockerfile to continue installing
iptables-legacy, and modify the proxy-init command to default to
iptables-legacy.

Signed-off-by: Andrew Seigner <[email protected]>
@siggy siggy self-assigned this Jan 24, 2024
@siggy siggy requested a review from a team as a code owner January 24, 2024 08:50
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! looks good to me! 👍

@mateiidavid mateiidavid merged commit 3d46473 into main Jan 25, 2024
11 checks passed
@mateiidavid mateiidavid deleted the siggy/iptables-legacy branch January 25, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants